Skip to content

Add support for setup functions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Add support for setup functions #38

merged 1 commit into from
Jun 23, 2025

Conversation

lucaswerkmeister
Copy link
Member

@lucaswerkmeister lucaswerkmeister commented Jun 17, 2025

No description provided.

@lucaswerkmeister
Copy link
Member Author

See also the corresponding Wikibase WIP change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1160175

These functions can e.g. add computed properties to the data array.
(They could also *delete* variables, but I don’t know when that would be
useful.)

Bug: T397223
@lucaswerkmeister lucaswerkmeister marked this pull request as ready for review June 18, 2025 13:35
@lucaswerkmeister lucaswerkmeister changed the title WIP: Add support for setup functions Add support for setup functions Jun 18, 2025
@lucaswerkmeister
Copy link
Member Author

I added tests, so I think this is ready for review now; I went for a somewhat more “realistic” test this time rather than the very minimal templates in some other tests, not sure why. (Let me know if you want to change it.)

@codders
Copy link
Contributor

codders commented Jun 23, 2025

Nice - let's give it a go!

@codders codders self-requested a review June 23, 2025 07:11
Copy link
Contributor

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you!

@codders codders merged commit cc9b51c into master Jun 23, 2025
8 checks passed
@codders codders deleted the setup branch June 23, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants